fix unsafeCompare #336
Merged
fix unsafeCompare #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ouch |
Member
|
Are you going to look into the now failing tests as well? |
Member
Author
|
For sure, I will revisit this failures, but later (in separate PRs). I think for now we need fix this string issue asap |
dcodeIO
reviewed
Nov 19, 2018
tests/compiler/std/string.ts
Outdated
| assert(dtoa(2.2250738585072014e-308) == "2.2250738585072014e-308"); | ||
| assert(dtoa(2.98023223876953125e-8) == "2.9802322387695312e-8"); | ||
| assert(dtoa(-2.109808898695963e+16) == "-21098088986959630.0"); | ||
| // assert(dtoa(2.98023223876953125e-8) == "2.9802322387695312e-8"); |
Member
There was a problem hiding this comment.
evaluates to 2.9802322387695315e-8
dcodeIO
reviewed
Nov 19, 2018
tests/compiler/std/string.ts
Outdated
| assert(dtoa(2.98023223876953125e-8) == "2.9802322387695312e-8"); | ||
| assert(dtoa(-2.109808898695963e+16) == "-21098088986959630.0"); | ||
| // assert(dtoa(2.98023223876953125e-8) == "2.9802322387695312e-8"); | ||
| // assert(dtoa(-2.109808898695963e+16) == "-21098088986959630.0"); |
Member
There was a problem hiding this comment.
evaluates to -21098088986959633.0
dcodeIO
reviewed
Nov 19, 2018
tests/compiler/std/string.ts
Outdated
| assert(dtoa(4294967272) == "4294967272.0"); | ||
| assert(dtoa(1.23121456734562345678e-8) == "1.2312145673456234e-8"); | ||
| assert(dtoa(-0.0000010471975511965976) == "-0.0000010471975511965976"); | ||
| // assert(dtoa(-0.0000010471975511965976) == "-0.0000010471975511965976"); |
Member
There was a problem hiding this comment.
evaluates to -0.0000010471975511965977
dcodeIO
reviewed
Nov 19, 2018
tests/compiler/std/string.ts
Outdated
| assert(dtoa(0.99999999999999995) == "1.0"); | ||
| assert(dtoa(1234e-2) == "12.34"); | ||
| assert(dtoa(0.1 + 0.2) == "0.30000000000000004"); | ||
| // assert(dtoa(0.1 + 0.2) == "0.30000000000000004"); |
Member
There was a problem hiding this comment.
evaluates to 0.30000000000000007
dcodeIO
reviewed
Nov 19, 2018
tests/compiler/std/string.ts
Outdated
|
|
||
| assert(dtoa(f32.MAX_VALUE) == "3.4028234663852886e+38"); | ||
| assert(dtoa(f32.EPSILON) == "1.1920928955078125e-7"); | ||
| // assert(dtoa(f32.MAX_VALUE) == "3.4028234663852886e+38"); |
Member
There was a problem hiding this comment.
evaluates to 3.4028234663852887e+38
dcodeIO
reviewed
Nov 19, 2018
tests/compiler/std/string.ts
Outdated
| assert(dtoa(f32.MAX_VALUE) == "3.4028234663852886e+38"); | ||
| assert(dtoa(f32.EPSILON) == "1.1920928955078125e-7"); | ||
| // assert(dtoa(f32.MAX_VALUE) == "3.4028234663852886e+38"); | ||
| // assert(dtoa(f32.EPSILON) == "1.1920928955078125e-7"); |
Member
There was a problem hiding this comment.
evaluates to 1.1920928955078126e-7
dcodeIO
reviewed
Nov 19, 2018
Closed
willemneal
pushed a commit
to willemneal/assemblyscript
that referenced
this pull request
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #335
Note: Some previous tests broken.